vue-query-synchronizer icon indicating copy to clipboard operation
vue-query-synchronizer copied to clipboard

Toggle between push() and replace() for router navigation method

Open omnichronous opened this issue 4 years ago • 2 comments

Adding the option to select replace() as the router navigation method, for cases where you don't want to keep the query changes in history.

omnichronous avatar Jan 05 '21 12:01 omnichronous

Hello Mitko,

sorry for not getting in touch earlier. We are in the process of converting our codebase to vue3 and I've added a slightly enhanced version of your pull request to the vue3 version of the library (no functioning npm build yet, working on it).

If you still want to merge your pull into vue 2 version, please let me know.

Thanks,

ms.

On Tue, 5 Jan 2021 at 13:48, Mitko Georgiev [email protected] wrote:

Adding the option to select replace() as the router navigation method, for cases where you don't want to keep the query changes in history.

You can view, comment on, or merge this pull request online at:

https://github.com/oarepo/vue-query-synchronizer/pull/9 Commit Summary

  • Toggle between push() and replace()

File Changes

Patch Links:

  • https://github.com/oarepo/vue-query-synchronizer/pull/9.patch
  • https://github.com/oarepo/vue-query-synchronizer/pull/9.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/oarepo/vue-query-synchronizer/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZ2SKQLSIC27BRQRMJLXLTSYMDA5ANCNFSM4VVB5C5Q .

mesemus avatar Mar 07 '21 11:03 mesemus

Thanks for implementing my suggestion @mesemus :) It would be great if you could merge it in the Vue 2 branch as well.

omnichronous avatar Apr 09 '21 09:04 omnichronous