Integrating icomplete-vertical into core Emacs

[phikal]

Hi,

there have been some discussions on the mailing list recently on integrating icomplete-vertical into core Emacs.

As fas as I see, there are two significant contributors (you and @protesilaos) that would require a copyright assignment, which shouldn't be too difficult.

There's a discussion going on here: https://lists.gnu.org/archive/html/emacs-devel/2020-06/msg00375.htm, if you'd like to join in or have any other questions.

Would be happy to see your package bundled in by default.

[protesilaos]

Thanks @phikal! I noticed the thread a few minutes ago :) I already have copyright assignment, as I have a couple of packages on GNU ELPA. Ask Stephan, if you need.

[oantolin]

I'd be happy to have icomplete-vertical in Emacs in some form. And I think rather than adding the package as is, it would make more sense to incoporate it into icomplete. The current implementation advises icomplete-completions, but it would make more sense to just modify that function slightly.

Also, some parts of this package seem a little over-engineered now with the benefit of hindsight. For example, the elaborate configuration system for icomplete-vertical-separator.

I haven't done the copyright assignment nor know how it is done.

[manuel-uberti]

@oantolin

Copyright assignment is a simple process. Residents of some countries can do it entirely electronically. We can help you get started, including sending you the forms you should fill, and answer any questions you may have (or point you to the people with the answers), at the [email protected] mailing list.

From: https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

[oantolin]

That mysterious paragraph is all the information I managed to find too, @manuel-uberti. I guess I have to write to the emacs-devel list if I want to actually find out.

[protesilaos]

Check this instead: https://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future

The name of the program just needs to be "Emacs"

[basil-conto]

If anyone's interested in the slightly more detailed CA spiel from a maintainer's PoV, it's at:

https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html

or, if you have this manual installed locally, e.g. via the gnulib Debian package, at:

(info "(maintain) Copyright Papers")

[dgutov]

In the meantime, @Ergus has been working on reimplementing this feature in the core.

Anybody interested should check out the feature/icomplete-vertical branch.

[oantolin]

That's great news, @dgutov ! Thanks to @ergus for picking up the ball I dropped! I've been swamped at work for a while now and am glad to see someone else do this.

[protesilaos]

Thank you @oantolin for all your contributions!

A couple of questions @Ergus, as I have never done this before:

1. How does one test it? Do I need to re-compile Emacs with that specific branch or is there some other way? I currently am on the master branch.
2. What is the right place to discuss this? emacs-devel?

[phikal]

Protesilaos Stavrou [email protected] writes:

1. How does one test it? Do I need to re-compile Emacs with that specific branch or is there some other way? I currently am on the master branch.

You could just check-out the branch, and load the changed files, but you'd have to do that every time you start you're local Emacs.

2. What is the right place to discuss this? emacs-devel?

There's a thread on the subject on emacs-devel.

-- Philip K.

[protesilaos]

Thank you @phikal!

[manuel-uberti]

FWIW, I've checked out the mentioned branch today to give it a spin and it seems on the right track. Let's thank @Ergus for this. :)

[phikal]

This has been added over a year ago, so this issue can be closed.