leapp-repository icon indicating copy to clipboard operation
leapp-repository copied to clipboard

Published 20 hours ago • verified publisher icon oamg

"refactor" the targetuserspacecreator actor (and other related)

Open pirat89 opened this issue 4 years ago • 1 comments

See the #482 PR. I have created bunch of TODOs with instructions (later will be added here). The current shape is really bad, but regarding the lack of time, I rather chose to skip such refactoring now and do it after the next release. The proper refactoring should take into account instruction in TODOs and should include properly written unit-tests covering the functionality properly (currently, unit tests cover just small part of the whole functionality). Affected actors and libraries:

  • targetuserspacecreator
  • systemfacts
  • libraries/rhsm.py

Probably new check actor(s) could be created as well.

pirat89 avatar Apr 06 '20 20:04 pirat89