convert2rhel icon indicating copy to clipboard operation
convert2rhel copied to clipboard

Add expected_returncode param to the fixture

Open danmyway opened this issue 2 years ago • 8 comments

  • expected_returncode defaults to 0, if any other returncode is expected specify the parameter

Jira Issues: RHELC-

Checklist

  • [ ] PR has been tested manually in a VM (either author or reviewer)
  • [ ] Jira issue has been made public if possible
  • [ ] [RHELC-] is part of the PR title
  • [ ] GitHub label has been added to help with Release notes
  • [ ] PR title explains the change from the user's point of view
  • [ ] Code and tests are documented properly
  • [ ] The commits are squashed to as few commits as possible (without losing data)
  • [ ] When merged: Jira issue has been updated to Release Pending if relevant

danmyway avatar Aug 31 '23 14:08 danmyway

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.08%. Comparing base (d607d64) to head (f328750). Report is 491 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          40       40           
  Lines        3889     3889           
  Branches      700      700           
=======================================
  Hits         3659     3659           
  Misses        164      164           
  Partials       66       66           
Flag Coverage Δ
centos-linux-7 89.14% <ø> (ø)
centos-linux-8 89.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 31 '23 14:08 codecov[bot]

/packit test


@oamg/conversions-qe please review results and provide ack.

has-bot avatar Aug 31 '23 14:08 has-bot

/packit test

danmyway avatar Aug 31 '23 17:08 danmyway

/packit test

danmyway avatar Aug 31 '23 19:08 danmyway

/packit test --labels tier0

danmyway avatar Sep 01 '23 10:09 danmyway

/packit test

danmyway avatar Sep 01 '23 13:09 danmyway

@danmyway What do you wanna do with this PR?

Venefilyn avatar Jul 31 '24 13:07 Venefilyn

@Venefilyn keeping this in a backlog for now. I might revisit until the end of this Q if everything else goes well.

danmyway avatar Jul 31 '24 14:07 danmyway

Closing this for now, might revisit later in the future.

danmyway avatar Oct 29 '24 14:10 danmyway