spec icon indicating copy to clipboard operation
spec copied to clipboard

Proposal: Follow traits schema to specify how app scopes are referenced by components

Open mikkelhegn opened this issue 5 years ago • 4 comments

In the operational (application) configuration, it's not specified how the applicationScopes are referenced: https://github.com/microsoft/hydra-spec/blob/master/6.application_configuration.md#component

Suggesting that we follow the schema defined for traits: https://github.com/microsoft/hydra-spec/blob/master/6.application_configuration.md#trait

Follow-up to #119

mikkelhegn avatar Sep 06 '19 06:09 mikkelhegn

Suggesting that we follow the schema defined for traits: https://github.com/microsoft/hydra-spec/blob/master/6.operational_configuration.md#trait

Thanks for the suggestion. But in the Configuration definition, it already contains the Scopes definitions in the same level as Components. I think the reason is that Scope could cross Component boundaries. In plain words, involve multiple components. So my conclusion is that we will keep Scopes definitions as is today, but define references in Components.

hongchaodeng avatar Sep 10 '19 00:09 hongchaodeng

Let's move discussion to https://github.com/microsoft/hydra-spec/issues/144 ?

hongchaodeng avatar Sep 13 '19 17:09 hongchaodeng

The problem is that we have only specified how scopes are created as part of an application configuration, not how components are added to a scope, unless we assume every component in an application configuration will be a member of all components in that one application configuration. That however goes against the whole idea of the application scopes.

mikkelhegn avatar Oct 04 '19 08:10 mikkelhegn

I think the whole idea is to reuse and reduce definitions. In fact I'm fine with either solution. But in last weekly meeting, that was the unanimous decision. @MikkelHegn Could you join the weekly next time and discuss your concerns?

hongchaodeng avatar Oct 04 '19 15:10 hongchaodeng