rudr icon indicating copy to clipboard operation
rudr copied to clipboard

rudr didn't implement properties and WorkloadSetting.value as described in spec

Open wonderflow opened this issue 6 years ago • 4 comments

We should make spec defined in rudr be consist with oam spec as soon as possible.

Value of WorkloadSetting

The type of value in workloadSetting can be any in OAM spec.

But in rudr, the value is serde_json::Value which in fact only json string cloud be deserialized.

Properties of Trait in Application Configuration

In OAM spec, there are two kinds of properties. One is json schema defined in Trait which in fact is json string, this is easy to understand. Another properties is used by trait binding in AppConfig, which should be dynamically defined by the trait's type.

In rudr, the second kind of properties is still defined as parameters.

wonderflow avatar Oct 10 '19 10:10 wonderflow

I hope to fix this but I'm really not sure how to define these two kinds of type in Rudr. Could you give me some advice and help?

@technosophos @suhuruli @hongchaodeng @resouer

wonderflow avatar Nov 15 '19 09:11 wonderflow

My personal feeling is, for an implementation (e.g. Rudr), its type is "subset" of OAM spec type is fine as long as it will not bring fragmentation to OAM.

resouer avatar Nov 19 '19 18:11 resouer

I agree. But I think we'd better give an example about how to solve this problem in Rudr. If not, other OAM runtime may be more confusing.

wonderflow avatar Nov 20 '19 07:11 wonderflow

My personal feeling is, for an implementation (e.g. Rudr), its type is "subset" of OAM spec type is fine as long as it will not bring fragmentation to OAM.

If Rudr only support yaml, and other implementation only support json. User must rewrite config before migration.

I prefer a determinate type rather than dynamic type.

fatkun avatar Nov 21 '19 02:11 fatkun