ovirt-web-ui icon indicating copy to clipboard operation
ovirt-web-ui copied to clipboard
verified publisher icon oVirt

Set tpm_enabled flag according to OS requirements

Open rszwajko opened this issue 3 years ago • 6 comments

Fixes: #1596 Depends on: https://github.com/oVirt/ovirt-engine/pull/514

For both new and edited VMs:

  1. set tpm_enabled = true if TPM support is required by the guest OS

For edited VMs:

  1. set tpm_enabled = false if TPM is not supported by the guest OS.
  2. require confirmation before disabling TPM as it may result in data loss.

rszwajko avatar Jul 05 '22 16:07 rszwajko

All tests passed

ovirt-infra avatar Jul 05 '22 16:07 ovirt-infra

TPM flag on Summary step (Create VM Wizard)

image

Confirmation message warning about potential data loss

image

rszwajko avatar Jul 05 '22 16:07 rszwajko

All tests passed

ovirt-infra avatar Jul 06 '22 11:07 ovirt-infra

All tests passed

ovirt-infra avatar Jul 06 '22 12:07 ovirt-infra

All tests passed

ovirt-infra avatar Jul 06 '22 13:07 ovirt-infra

All tests passed

ovirt-infra avatar Jul 07 '22 14:07 ovirt-infra

/ost

sjd78 avatar Sep 19 '22 17:09 sjd78

/ost

sjd78 avatar Sep 20 '22 15:09 sjd78

/ost

rszwajko avatar Sep 21 '22 08:09 rszwajko

@sgratch fixed the scenarios pointed above - please review again.

rszwajko avatar Sep 29 '22 13:09 rszwajko

/ost

sgratch avatar Sep 30 '22 08:09 sgratch

OST failed 3 times in test_verify_add_hosts (didn't get to ui tests yet) so merging without waiting for OST to succeed.

sgratch avatar Sep 30 '22 10:09 sgratch