ovirt-system-tests icon indicating copy to clipboard operation
ovirt-system-tests copied to clipboard

Published 20 hours ago • verified publisher icon oVirt

ui: User portal and Grafana tests in a separate Selenium session

Open tinez opened this issue 2 years ago • 6 comments

  • selenium: Remove unused 'selenium_version' fixture
  • selenium: Move fixtures to fixtures.selenium for reuse
  • ui: Move some fixtures to 'fixtures.ui' module
  • ui: Remove unused imports and objects
  • ui: Separate user portal and grafana tests from other UI tests

tinez avatar Sep 28 '22 16:09 tinez

/ost

ljelinkova avatar Sep 29 '22 07:09 ljelinkova

Right, so in the latest run test_logout failed and it's not really relevant with the current PR, so we can remove it.

tinez avatar Sep 29 '22 09:09 tinez

/ost

tinez avatar Sep 29 '22 09:09 tinez

I don't know...so what does this actually solve and how?

michalskrivanek avatar Sep 29 '22 11:09 michalskrivanek

I don't know...so what does this actually solve and how?

It solves the problem of user portal tests failing. We're simply running a completely new Selenium setup for user portal and Grafana tests. The gist of the PR is changing scope=session to scope=module. The rest is just shuffling stuff around and a cleanup.

tinez avatar Sep 29 '22 12:09 tinez

and what is it going to help with? IIUC it won't necessarily affect the logout/keycloak problem

michalskrivanek avatar Sep 29 '22 12:09 michalskrivanek