ovirt-engine icon indicating copy to clipboard operation
ovirt-engine copied to clipboard

fix ansible lint seperate commits

Open dangel101 opened this issue 2 years ago • 13 comments

  • fix ansible lint: risky file permissions: File permissions unset or incorrect
  • fix ansible lint: risky-shell-pipe: Shells that use pipes should set the pipefail option
  • fix ansible lints: - role-name: Role name does not match ^*$ pattern. - name: All tasks should be named. (name[missing])
  • fix ansible lint: package-latest: Package installs should not use latest
  • fix ansible lint: no-changed-when: Commands should not change things if nothing needs doing
  • fix ansible lints: - command-instead-of-module: systemctl used in place of systemd module (+ merged tasks), rpm used in place of yum or rpm_key module - command-instead-of-shell: Use shell only when shell functionality is required
  • fix ansible lint: ignore-errors: Use failed_when and specify error conditions instead of using ignore_errors
  • fix ansible lint: no-handler: Tasks that run when changed should likely be handlers
  • adding ansible-lint tests to CI (oVirt#484)

Fixes: https://github.com/oVirt/ovirt-engine/issues/710

dangel101 avatar Sep 28 '22 11:09 dangel101

/ost

dangel101 avatar Sep 28 '22 11:09 dangel101

/ost

dangel101 avatar Sep 29 '22 12:09 dangel101

about the titles- it's because the title is long, looks like it was split automatically

Make sure each commit message has its short single-line title, separated from the following content by a blank line.

mz-pdm avatar Oct 03 '22 09:10 mz-pdm

about the titles- it's because the title is long, looks like it was split automatically

Make sure each commit message has its short single-line title, separated from the following content by a blank line.

done

dangel101 avatar Oct 03 '22 11:10 dangel101

@mz-pdm I pushed the fixes we discussed thanks

dangel101 avatar Oct 06 '22 12:10 dangel101

/ost

dangel101 avatar Oct 06 '22 12:10 dangel101

/ost

mwperina avatar Oct 07 '22 08:10 mwperina

/ost

mwperina avatar Oct 07 '22 12:10 mwperina

/ost

mwperina avatar Oct 10 '22 07:10 mwperina

/ost

mwperina avatar Oct 10 '22 09:10 mwperina

/ost

mwperina avatar Oct 10 '22 12:10 mwperina

/ost

mwperina avatar Oct 10 '22 13:10 mwperina

/ost he-basic-suite-master

mwperina avatar Oct 10 '22 13:10 mwperina

/ost

dangel101 avatar Oct 19 '22 12:10 dangel101

/ost

dangel101 avatar Oct 19 '22 13:10 dangel101

/ost

dangel101 avatar Oct 20 '22 07:10 dangel101

/ost

dangel101 avatar Oct 20 '22 09:10 dangel101

/ost

dangel101 avatar Oct 20 '22 11:10 dangel101

/ost

dangel101 avatar Oct 23 '22 07:10 dangel101

/ost

dangel101 avatar Oct 23 '22 09:10 dangel101

/ost

dangel101 avatar Oct 24 '22 08:10 dangel101

/ost

dangel101 avatar Oct 24 '22 11:10 dangel101

/ost

dangel101 avatar Oct 25 '22 15:10 dangel101

/ost

dangel101 avatar Oct 26 '22 08:10 dangel101

/ost

dangel101 avatar Oct 26 '22 11:10 dangel101