ovirt-engine icon indicating copy to clipboard operation
ovirt-engine copied to clipboard

Published 20 hours ago • verified publisher icon oVirt

Skip disk profiles validation on memory disk

Open liranr23 opened this issue 2 years ago • 2 comments

When we create the memory or metadata disks they are a result of live snapshot with memory or hibernation command. In some cases the user can own the VM, including the option to execute the above command but he may not have the disk profile permission to add those disks.

This patch will skip the permission validation in those cases, allowing a user that owns the VM and capable of executing the command to not fail on the underlying addDisk command.

Change-Id: Ib04048d652c8d98df84ffccc4babd71730b218dc Bug-Url: https://bugzilla.redhat.com/1565183 Signed-off-by: Liran Rotenberg [email protected]

liranr23 avatar Aug 17 '22 09:08 liranr23

/ost

liranr23 avatar Aug 17 '22 14:08 liranr23

/ost

liranr23 avatar Aug 21 '22 08:08 liranr23

There is a typo in the commit message ("virutal disks").

thanks, updated.

liranr23 avatar Aug 22 '22 06:08 liranr23

There is a typo in the commit message ("virutal disks").

thanks, updated.

also the following doesn't describe accurately what this PR does now: This patch will skip the permission validation in those cases, allowing a user to create attach disks for disks that are not a real virtual disks.

ahadas avatar Aug 22 '22 06:08 ahadas

also the following doesn't describe accurately what this PR does now: This patch will skip the permission validation in those cases, allowing a user to create attach disks for disks that are not a real virtual disks.

changed.

liranr23 avatar Aug 22 '22 07:08 liranr23

/ost

ahadas avatar Aug 23 '22 06:08 ahadas