ovirt-engine icon indicating copy to clipboard operation
ovirt-engine copied to clipboard

Published 20 hours ago • verified publisher icon oVirt

core: Support virtio ISO from data domain in VM import

Open smelamud opened this issue 2 years ago • 2 comments

Path to a virtio ISO image used in VM import was constructed assuming that the image is located in an ISO domain. To support ISO images located in a data domain we need to pass the storage domain ID to ConvertVmCommand and use prepareImage()/teardownImage() to obtain the path to the image on the host where VM conversion is running.

Due to limitation of prepareImage()/teardownImage() on VDSM side, these calls cannot be nested. That's why the ISO image located in a data domain can be used exclusively by a single instance of ConvertVmCommand. Usage of it by any running VM or by other ConvertVmCommand instances in the same time is prohibited.

Change-Id: I835602a9019ecbcf4c63529a9d006bc43ee793be Bug-Url: https://bugzilla.redhat.com/1721455 Signed-off-by: Shmuel Melamud [email protected]

smelamud avatar Aug 03 '22 02:08 smelamud

Looks good to me.

mz-pdm avatar Aug 18 '22 06:08 mz-pdm

@mz-pdm So, can you approve?

smelamud avatar Aug 21 '22 16:08 smelamud