ovirt-engine-sdk icon indicating copy to clipboard operation
ovirt-engine-sdk copied to clipboard

Published 20 hours ago • verified publisher icon oVirt

Fixed attach disk before create snapshots and other minor bug

Open fmgb opened this issue 5 years ago • 3 comments

When I use this script always I have to execute it twice and attach disk manually. Because the script doesn't attach disk to vm automatically. And when the script tries to create a snapshot, it failed.

  • Fixed get path in call to get_image_chain Get path 'disks/' correctly before call get_image_chain.

  • Added a comment in disk option "Sparse" when the disk will be created in iSCSI Storage Domain. In iSCSI Storage if the disk is RAW should be Sparse=False.

fmgb avatar Feb 10 '20 16:02 fmgb

Hello @fmgb. Thank you very much for your contribution. This project don't use github a tool for contribution, but it's just a mirror for the gerrit project. Could you please send the patch via gerrit? Here is a documentation how to work with gerrit. Thank you.

cc @oliel

machacekondra avatar Feb 19 '20 07:02 machacekondra

Hi @fmgb, I don't see these changes in our codebase, have they been posted using gerrit, as Ondra has suggesteed?

oliel avatar Apr 26 '21 07:04 oliel

@fmgb can you please rebase and solve conflicts?

sandrobonazzola avatar Jul 06 '22 08:07 sandrobonazzola