oUF icon indicating copy to clipboard operation
oUF copied to clipboard

leaderindicator: Differentiate between leaders and guides

Open ls- opened this issue 3 years ago • 6 comments

It's been a while since these were added, but there's actually 2 types of leaders, guides and leaders, the former are leaders of parties formed via LFD/LFR. In the default UI they use different icons. Also, those UnitIn* checks are unnecessary.

ls- avatar Aug 31 '21 06:08 ls-

This PR went full circle 😁🔫

ls- avatar Aug 31 '21 09:08 ls-

@ls- do you want to remove default textures next expac or why the compat mode thingy?

Rainrider avatar Feb 28 '22 20:02 Rainrider

@Rainrider I originally wanted to push this stuff during SL, so I added the compat mode thingy, but I decided to delay it until the next xpack, so I'll remove it later on. Also, I don't remember removing those labels, wtf? 🤔

ls- avatar Feb 28 '22 20:02 ls-

Is it possible to merge LeaderIndicator and AssistantIndicator into one? There shouldn't be someone mark as both roles, right?

siweia avatar Jun 21 '22 16:06 siweia

Is it possible to merge LeaderIndicator and AssistantIndicator into one? There shouldn't be someone mark as both roles, right?

Given the new functionality of the leader indicator, I'm not sure about that. But I'll review it for the next major. We'll see.

ls- avatar Jul 18 '22 04:07 ls-

There shouldn't be someone mark as both roles, right?

You could have both, yes. You can be the leader or an assistant of a normal group and the oposite of an instance group. Although this is a rare situation that I've yet to encounter myself, and I doubt there's any point in supporting it.

p3lim avatar Jul 18 '22 14:07 p3lim

Merged into #613.

ls- avatar Oct 20 '22 22:10 ls-