DownOnSpot icon indicating copy to clipboard operation
DownOnSpot copied to clipboard

Add argument parser & skip already downloaded songs

Open breuerfelix opened this issue 3 years ago • 9 comments

Signed-off-by: Felix Breuer [email protected]

breuerfelix avatar Jan 19 '22 16:01 breuerfelix

Can you split this PR so we have a separate PR for the argument parser and skipping downloads? I would like to merge the later

oSumAtrIX avatar Mar 02 '22 13:03 oSumAtrIX

@oSumAtrIX is this being worked on?

sraka1 avatar May 18 '22 18:05 sraka1

Currently on hold, since I am working on some other projects, you can use the fork though

oSumAtrIX avatar May 18 '22 22:05 oSumAtrIX

well it is finished and working, i just do not have the time in splitting this into two seperate PRs i can rebase it though, if you wanna merge it in one PR (it is split into different commits tho)

breuerfelix avatar Jun 07 '22 08:06 breuerfelix

Looking forward to this feature !

varac avatar Jun 17 '22 06:06 varac

Very useful feature! I will be using the fork for a bit in order to see if it works.

mossepso avatar Nov 27 '22 08:11 mossepso

@oSumAtrIX if you plan on merging this, i can rebase and update the branch :) just let me know

breuerfelix avatar Dec 01 '22 08:12 breuerfelix

I forgot to send the requested changes, they were pending for all these months 💀

oSumAtrIX avatar Dec 01 '22 10:12 oSumAtrIX

haha :D the problem is, that this PR is (until today) my first and only touching point with rust... so i am not that good at rust and i also don't know all these best practices or how to implement them. for example, i thought you use the unwrap_or function to set default values. that means, i have no clue on how to do this in another way :D

so: i can rebase this pr but i am not able to implement your changes, maybe someone else can fix them or maybe we can merge my pr to a branch for you as a starting point so you can refactor this a little bit :)

breuerfelix avatar Dec 01 '22 11:12 breuerfelix