droidVncServer icon indicating copy to clipboard operation
droidVncServer copied to clipboard

Compile failure jni/jpeg/jidctfst.S

Open liuqun opened this issue 7 years ago • 3 comments

E:\workspace\upstream\droidVncServer\jni>ndk-build
Android NDK: WARNING: APP_PLATFORM android-15 is larger than android:minSdkVersi
on 4 in E:/workspace/upstream/droidVncServer/AndroidManifest.xml
libpng: Ignoring gcc flag -fvisibility=hidden  on Cygwin
libpng: Ignoring gcc flag -fvisibility=hidden  on Cygwin
libpng: Ignoring gcc flag -fvisibility=hidden  on Cygwin
libpng: Ignoring gcc flag -fvisibility=hidden  on Cygwin
[armeabi] Compile arm    : jpeg <= jidctfst.S
E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S: Assembler messages:
E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:66: Error: missing ')'
E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:66: Error: garbage foll
owing instruction -- `pld (r2,#0)'
E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:259: Error: missing ')'

E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:259: Error: garbage fol
lowing instruction -- `pld (sp,#32)'
E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:271: Error: missing ')'

E:/workspace/upstream/droidVncServer/jni/jpeg/jidctfst.S:271: Error: garbage fol
lowing instruction -- `pld (ip,#32)'
make.exe: *** [E:/workspace/upstream/droidVncServer/obj/local/armeabi/objs/jpeg/
jidctfst.o] Error 1

Compile arm    : jpeg <= jidctfst.S
jni/jpeg/jidctfst.S: Assembler messages:
jni/jpeg/jidctfst.S:259: Error: missing ')'
jni/jpeg/jidctfst.S:259: Error: garbage following instruction -- `pld (sp,#32)'
jni/jpeg/jidctfst.S:271: Error: missing ')'
jni/jpeg/jidctfst.S:271: Error: garbage following instruction -- `pld (ip,#32)'
make: *** [obj/local/armeabi/objs/jpeg/jidctfst.o] Error 1

liuqun avatar Jul 16 '16 03:07 liuqun

consider upgrade libjpeg from version 6b to higher?

http://libjpeg.sourceforge.net/ http://libjpeg.cvs.sourceforge.net/viewvc/libjpeg/libjpeg/ http://www.ijg.org/files/jpegsrc.v6b.tar.gz

liuqun avatar Jul 16 '16 03:07 liuqun

see also issue #104 and issue #53 Thanks to @chtisgit ‘s patch https://github.com/oNaiPs/droidVncServer/files/275607/droidvncserver.diff.zip

diff --git a/jni/jpeg/jidctfst.S b/jni/jpeg/jidctfst.S
index 34e1c24..59e9848 100755
--- a/jni/jpeg/jidctfst.S
+++ b/jni/jpeg/jidctfst.S
@@ -63,7 +63,7 @@


 jpeg_idct_ifast:
-    PLD     (r2, #0)
+    pld     [r2, #0]
     stmdb   sp!, {r4,r5, r6,r7, r8,r9, r10,r11, r12,lr}
     ldr     r4, [sp, #4*10]
     sub     sp, #local_SIZE
@@ -256,7 +256,7 @@ VLoopHead:

 HLoopStart:
     // reset pointers
-    PLD     (sp, #off_WORKSPACE)
+    pld     [sp, #off_WORKSPACE]
     add     ip, sp, #off_WORKSPACE
     ldr     r10, local_RANGE_TABLE

@@ -268,7 +268,7 @@ HLoopTail:
     str      r0, local_OUTPUT_BUF
     add      fp, r2, r1

-    PLD      (ip, #32)
+    pld      [ip, #32]
     ldmia    ip!, {r0-r7}

     cmp      r1, #0

liuqun avatar Jul 16 '16 03:07 liuqun

and also set ANDROID_JPEG_NO_ASSEMBLER:=true in /jni/jpeg/Android.mk

liuqun avatar Jul 16 '16 04:07 liuqun