o3de-extras
o3de-extras copied to clipboard
Currently `JointsManipulationRequests` uses redundant namespace.
JointsManipulationRequests
is a bus that allows to affect manipulators using in-o3de communication.
It has address policy by EntityId
, and allows developers to affect the joints of the robot using method like:
virtual AZ::Outcome<void, AZStd::string> MoveJointToPosition(const AZStd::string& jointName, JointPosition position) = 0;
The problem is that if the robot has a namespace that was set with the ROS2 Frame component, it will affect jointName
argument of the above-mentioned function.
This is problematic since:
- namespace is ROS / ROS 2 concept
- the bus has already a key (EntityId), namespace is a redundant key. Please:
- [ ] remove need to pass unnecessarily namespace to functions in
JointsManipulationRequests
- [ ] adjust all points of contact with ROS2 non-exhaustive list :
- JointStatePublisher
- JointsTrajectoryComponent
- JointsTrajectoryComponent
- Revert #498