onefetch icon indicating copy to clipboard operation
onefetch copied to clipboard

Astro support

Open v36u opened this issue 2 years ago • 4 comments
trafficstars

Language Name 🖊

The name of the framework is "Astro".

Official docs: https://docs.astro.build/

Not mentioned in the README, but it seems that tokei supports Astro: https://github.com/XAMPPRocky/tokei/blob/c8e4d0703252c87b1df45382b365c6bb00769dbe/languages.json#L85-L89

Logo 📷

White "A": https://astro.js.org/astro.png Black "A": https://raw.githubusercontent.com/github/explore/5cc0a03a302ec862c4aeac2a22a513ae31c35432/topics/astro/astro.png

Upstream support ✅

  • [X] Does tokei already support the language in question?

v36u avatar Oct 17 '23 17:10 v36u

The latest release of tokei was a pre-release 7 months ago. Astro was added 6 months ago (https://github.com/XAMPPRocky/tokei/commit/fb2a612e76738e578af17104fd3ab82d2f81983b), so I'll mark this as an upstream issue for now.

Also, see these issues/PRs :wink:

  • https://github.com/o2sh/onefetch/pull/1152
  • https://github.com/spenserblack/gengo/issues/34

spenserblack avatar Oct 17 '23 17:10 spenserblack

Off-topic: @o2sh How do you feel about using a tokei pre-release? With 13.0.0-alpha.0 I think we could merge https://github.com/o2sh/onefetch/pull/940 and https://github.com/o2sh/onefetch/pull/523

spenserblack avatar Oct 17 '23 17:10 spenserblack

I'd be cautious about using a pre-release version for such an important feature, especially considering tokei's slow update schedule. If we need fixes, it might take a while 😓 .

o2sh avatar Oct 21 '23 21:10 o2sh

Hi, i try to fix this with #1317

EliasLeguizamon123 avatar Apr 23 '24 21:04 EliasLeguizamon123