quepid icon indicating copy to clipboard operation
quepid copied to clipboard

Richer display of scorers

Open epugh opened this issue 2 years ago • 5 comments

Description

adding in tool tip and description, and more critically, splitting how we calculate the score for "per query" and "per case". I.e, a score for query, and then your CaseScore is overall.... @david-fisher says we shouldn't just Average with every scorer, that some should be a Sum instead.

Motivation and Context

Make CaseScore, which I have in the past called your QScore... your QuepidScore... More meaningful...

Give newbie users a better sense of which scorer they should reach for!

How Has This Been Tested?

Still need to work on this.

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [X ] Breaking change (fix or feature that would cause existing functionality to change)

epugh avatar Aug 27 '22 13:08 epugh

I've added a sumQueries method to join the existing avgQueries method on the https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L211 class... It's a placeholder and still does averaging! However, I don't quite understand how that all intersects with the runScores method, where the actual logic maybe occurs? https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L134

I'd love some ideas or fixes @david-fisher @worleydl !

epugh avatar Aug 27 '22 14:08 epugh

I've added a sumQueries method to join the existing avgQueries method on the https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L211 class... It's a placeholder and still does averaging! However, I don't quite understand how that all intersects with the runScores method, where the actual logic maybe occurs? https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/controllers/queriesCtrl.js#L134

I'd love some ideas or fixes @david-fisher @worleydl !

I believe the averaging happens in https://github.com/o19s/quepid/blob/richer_display_of_scorers/app/assets/javascripts/services/queriesSvc.js line 1033 when setting the svc.latestScoreInfo inside the scoreAll function (line 991). Angular is not my thing, but that does seem to be the culprit.

david-fisher avatar Aug 30 '22 13:08 david-fisher

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

stale[bot] avatar Jan 07 '23 17:01 stale[bot]

Bump

epugh avatar Apr 19 '23 19:04 epugh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please do advocate for this issue and ideally submit a patch to get the attention of the maintainers!

stale[bot] avatar Sep 17 '23 02:09 stale[bot]