o1js icon indicating copy to clipboard operation
o1js copied to clipboard

Check examples for vulnerabilities

Open garwalsh opened this issue 9 months ago • 1 comments

Check examples https://github.com/o1-labs/o1js/tree/main/src/examples and tutorial code, code snippets for vulnerabilities

garwalsh avatar May 09 '24 16:05 garwalsh

This task in interesting. What we want to avoid: providing examples that developers might copy and paste and end up with vulnerable zkApps. But we also don't want to make the examples so complicated that they don't serve their purpose (to simply explain concepts)

So the task here is to work through the examples and drop warnings in the comments if a pattern we use to illustrate a concept is unsuitable for a production zkApp.

Maybe it's just a boilerplate comment that we add to the top of all of them.

Happy to talk this through with whoever picks it up (probably once that person has had a chance to look through the current examples with this context in mind)

garwalsh avatar Jul 11 '24 21:07 garwalsh