docs2 icon indicating copy to clipboard operation
docs2 copied to clipboard

Major upgrade merge main

Open halsaphi opened this issue 1 year ago • 7 comments

Merging main into major-upgrade to sync major-upgrade branch with latest changes on main. In preparation to releasing the updated docs for the hard fork.

Please note: Have removed info boxes stating zkApps are not available on mainnet.

Have fixed broken links and accepted changes from main to fix conflicts.

halsaphi avatar May 20 '24 06:05 halsaphi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 5:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview May 22, 2024 5:30am

vercel[bot] avatar May 20 '24 06:05 vercel[bot]

Someone is attempting to deploy a commit to the o1labs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 20 '24 06:05 vercel[bot]

@Trivo25 This was merged from main today.

halsaphi avatar May 20 '24 15:05 halsaphi

@Trivo25 correct me if I am wrong, but camelCase used in typescript samples and snake_case - in python. according to styles preferred by these communities

qwadratic avatar May 20 '24 15:05 qwadratic

@Trivo25 correct me if I am wrong, but camelCase used in typescript samples and snake_case - in python. according to styles preferred by these communities

Here are the two styles mixed up - relatedIdxs and op_type for example.

function makeOperation(idx: number, relatedIdxs: number[], op_type: string, addr: string, value: number, isPositive: boolean) {

Other than that, I think it would be beneficial to let a linter run over the code examples, snippets like these

return {
        block_identifier: {[identifierKey]: idOrHash}
}

can be improved for better readability

return {
    block_identifier: {
        [identifierKey]: idOrHash
    }
}

Sometimes spaces and indentations are off as well

Trivo25 avatar May 20 '24 16:05 Trivo25

ok I will do it tomo

qwadratic avatar May 20 '24 16:05 qwadratic

@Trivo25

Thank you for the suggestion, nice catch. While it is on my backlog, I suggest to merge this PR and do the change you suggested as a separate one. wdyt?

qwadratic avatar May 21 '24 07:05 qwadratic