docs2 icon indicating copy to clipboard operation
docs2 copied to clipboard

Rename deprecated assert* to require* in o1js precondition APIs

Open mitschabaude opened this issue 1 year ago • 11 comments

adapt docs to https://github.com/o1-labs/o1js/issues/1247

mitschabaude avatar Nov 27 '23 06:11 mitschabaude

cc @LuffySama-Dev

mitschabaude avatar Nov 27 '23 07:11 mitschabaude

cc @LuffySama-Dev

Hi Gregor, Thanks for assigning. I will get started with it 🙋.

Thank You 😄

LuffySama-Dev avatar Nov 27 '23 07:11 LuffySama-Dev

Hi @mitschabaude ,

I am facing some issue when I am trying to install the o1js, as new version of o1js package has not been released yet, I am unable to install it locally via npm and can't test the examples.

  1. Is there any other way which I can try this?
  2. I need to update the docs and examples only right ?
  3. Will it be okay if the examples have the latest o1js version installed in them ?

Thank You 😃

LuffySama-Dev avatar Nov 28 '23 07:11 LuffySama-Dev

@LuffySama-Dev good question! you can install o1js from a local folder like npm i ../o1js and just not commit that change yet. and then when it's released we update your PR to use the latest version and merge it?

mitschabaude avatar Nov 30 '23 18:11 mitschabaude

Awesome !!

Will make the changes and update here once ready 🙌🙌

LuffySama-Dev avatar Nov 30 '23 18:11 LuffySama-Dev

@LuffySama-Dev FYI, the new o1js version that has these changes has been released.

ymekuria avatar Dec 17 '23 22:12 ymekuria

Hi @ymekuria ,

Thanks for letting me know. I will get started with it.

LuffySama-Dev avatar Dec 18 '23 03:12 LuffySama-Dev

Hi @mitschabaude , @ymekuria , @barriebyron

I have raised the Pull request number #786 . Can you please review it ?

Thanks

LuffySama-Dev avatar Dec 20 '23 07:12 LuffySama-Dev

thanks @LuffySama-Dev for this good work! We are now looking at the two "unnumbered easy-to-skip" tutorials that need the same love https://docs.minaprotocol.com/zkapps/tutorials/anonymous-message-board https://docs.minaprotocol.com/zkapps/tutorials/interacting-with-zkapps-server-side

Would you be up for working with me on these?

barriebyron avatar Feb 23 '24 16:02 barriebyron

Hi @barriebyron ,

Yes sure. I would love too work on it.

Thank You 😊

LuffySama-Dev avatar Feb 23 '24 18:02 LuffySama-Dev

Hi @barriebyron ,

Let me know when we can start ? Also, I am not sure what to do 😅😅. So, can you please help to explain?

Thank You 😃

LuffySama-Dev avatar Mar 07 '24 15:03 LuffySama-Dev