anise icon indicating copy to clipboard operation
anise copied to clipboard

Introduce has_velocity_dynamics

Open gwbres opened this issue 1 year ago • 3 comments

  • Simple method to determine whether velocity/dynamics are present, which allows pos_vel() exploitation and helps determine whether full or partial rotation may apply

gwbres avatar Aug 15 '24 09:08 gwbres

The tests fail because of some change I introduced the other day which should specifically prevent this. There's a specific BSP file that is stored in the secrets and only available to me as a maintainer, so I tried to skip the test if that env var isn't available. Obviously that does not work.

ChristopherRabotin avatar Aug 15 '24 15:08 ChristopherRabotin

The tests fail because of some change I introduced the other day

no worries 👍 I'm also thinking maybe this new method should simply be named has_velocity

gwbres avatar Aug 15 '24 15:08 gwbres

I guess what I'm now wondering is whether your application could directly use state.vmag_km_s() > 0.0 directly? I have no strong opinions here.

ChristopherRabotin avatar Aug 15 '24 15:08 ChristopherRabotin