Yuri Astrakhan comments

Results 987 comments of


                                            Yuri Astrakhan

mbtiles does not validate `{min,max}zoom` metadata fileds

yep, we can even use these files in unit tests to generate in-memory sqlite dbs - makes testing far easier

Suggest `std::sync::LazyLock` instead of `once_cell::sync::Lazy`

thx!! Do we really want to mention 3rd party crates when the exact same functionality is available in stdlib?

Can't build by `cargo build`

I also hit this issue - the onboarding is really confusing - should the `build.rs` do some extra checks and print a useful message instead? Or have some defaults that...

Can't build by `cargo build`

@devsnek could you adjust the README? This section is really confusing, as it implies that `git clone` with submodules + `cargo build` should work from the start. > Binaries builds...

Introduce `CFG.change_detection` bool flag

@dtolnay does this implement what you meant in your comment?

just_executable() and other functions return the native path, not the cygpath, when in Windows

This behavior is confusing in GitHub CI, which seems to always use `bash` by default, including on Windows. As a result, this command does not work consistently in CI. I...

just_executable() and other functions return the native path, not the cygpath, when in Windows

P.S. @casey take a look at [path-slash](https://crates.io/crates/path-slash) crate for the internal translation, but that might not fix my issue above

Fix the `workspace::alloc` API to be safe

You are correct - the alloc function is safe by itself - the issue is that the API from it returns a `&[u8]` - a slice pointing to individual bytes,...

Supporting format! is fairly simple: ```rust // usage let name = "world"; write!(workspace, "Hello, {name}!").unwrap(); // impelementation impl fmt::Write for Workspace { fn write_str(&mut self, s: &str) -> fmt::Result {...

formatting macros

Another possible idea - create a temporary writer object - similar to how mutex lock guard works. On writer creation, the empty space of a workspace is reserved. Once it...