openapi2proto icon indicating copy to clipboard operation
openapi2proto copied to clipboard

Don't prefix enums unless namespace-enums is true

Open agasparovic-sabre opened this issue 4 years ago • 2 comments

The -namespace-enums command-line flag doesn't seem to be working because of this. (I've tried it true/false with no effect either way - it always adds prefixes. I can provide a repro if needed.)

agasparovic-sabre avatar May 01 '20 04:05 agasparovic-sabre

Hi maintainers! I see the failing tests here and am hoping for a bit of guidance - should I attempt to fix the tests, or change the default value of -namespace-enums to true (since it seems that it's always on right now)?

agasparovic-sabre avatar May 12 '20 14:05 agasparovic-sabre

Hi @jprobinson, not sure if you're still working on this codebase but was hoping for a bit of advice on the above. Thanks!

agasparovic-sabre avatar May 14 '20 22:05 agasparovic-sabre