library icon indicating copy to clipboard operation
library copied to clipboard

Build fails on node 20 (node-sass version in package-lock.json stops working after node 18)

Open jpmckinney opened this issue 1 year ago • 2 comments

Context (Environment)

All in issue title.

Expected Behavior

Build succeeds on node 20.

Actual Behavior

Build fails on node 20.

To Reproduce

npm run build:main && npm run build:inline on node 20.

Additional Information

N/A

Possible Solution

Not sure - maybe have branches/releases for node20 and node18, since they require different package-lock.json.

My current workaround is just to lock the engine to 18 in both package files (smallest edit).

jpmckinney avatar May 08 '23 17:05 jpmckinney

Hi @jpmckinney, thanks for the issue. We currently we officially support 14.x, 16.x, 18.x, but will definitely look into getting node 20 working now that it's LTS!

afischer avatar May 08 '23 20:05 afischer

I'm actually experiencing this on node 16 as well, even though it's officially supported. The only way I was able to fix it was to completely replace node-sass (which is deprecated anyways) with dart-sass. I can make a PR if that helps.

Morred avatar Jun 21 '23 07:06 Morred