I updated your ice plugin to the best of my ability for TinyMCE v 4

[catsgotmytongue]

I thought you would appreciate this as I changed it for the app I'm currently working on and it should be a working plugin for tinymce4 now.

Btw, Thanks for the awesome plugin it has saved me tons of work and I really appreciate that.

[delambo]

Thanks @catsgotmytongue. Did you need to make any changes to any of the src/*.js ice files?

[catsgotmytongue]

The only updates I made had to do with tinymce plugin.js( in 3.5.8 it was editor_plugin.js). The buttons don't toggle due to the fact that MCE 4 does not use the ControlManager manager class anymore, but that could get fixed when I figure out how to do it in 4. On Jul 2, 2013 7:57 PM, "Matthew DeLambo" [email protected] wrote:

Thanks @catsgotmytongue https://github.com/catsgotmytongue. Did you need to make any changes to any of the src/*.js ice files?

— Reply to this email directly or view it on GitHubhttps://github.com/NYTimes/ice/pull/76#issuecomment-20392785 .

[Parivalavan]

Hi, I'm using TinyMCE 4 and the forked version of catsgotmytongue. When we try to delete a block of text that involves text from two consecutive para, then the delete is not tracked. To repeat it try deleting the text "... Long Island called Talon Air.

But when the subject was ..." from the demo you have provided.

1. The delete/backspace key deletes the text but does not track changes. You could see this behavior Firefox, it works as expected on Chrome.
2. The enter key deletes the text but does not track change. This could be seen in both Firefox (V24) and Chrome (V30.0.1599.69 m).

When I tried to debug, the deleteContents function from ice.js is not called as expected. Any advice/suggestion is welcome. Thanks, Pari

[NullVoxPopuli]

hi @catsgotmytongue and @Parivalavan I've used @catsgotmytongue's most recent code and pulled in the most recent upstream changes into https://github.com/NYTimes/ice/pull/105, if you want to take a look.

[sarankup]

I am new. Please advise where to download ice plugin for Tinymce4.0 Jquery version. I could not plug-in the ice-master in TinyMCE JQM 4.0

[jhermiz]

@catsgotmytongue - can you please help me and give some more details. I downloaded your changes as a zip but I'm not sure what to place into the tinymce plugins folder. If I try to place the ice and icesearchreplace from what you have within tinymce/plugins I get uncaught reference errors. Can you please explain what we need to do to get this working. PS: THANK SO MUCH!

[catsgotmytongue]

wow it's been a while since I worked on it so I'd have to get my head around it again.

I'll try to look into it this tomorrow or friday.

[jhermiz]

Thanks so much Curt.

Basically we are using the latest tinymce…and I followed what you mentioned but I’m not sure what files to place anywhere.

It seems when I do as the documentation on nytimes says it is looking for a ice.min.js plugin..which doesn’t exist. So I landed on your branch copy where you mentioned you got this thing to work specifically for tinymce.

I would love it if you could please help me set this up…as I do not want to reinvent the wheel of tracking changes.

Thanks again Curt.

Jon

From: Curt Mullin [mailto:[email protected]] Sent: Wednesday, October 29, 2014 10:51 PM To: NYTimes/ice Cc: JonH Subject: Re: [ice] I updated your ice plugin to the best of my ability for TinyMCE v 4 (#76)

wow it's been a while since I worked on it so I'd have to get my head around it again.

I'll try to look into it this tomorrow or friday.

On Wed, Oct 29, 2014 at 10:05 AM, JonH [email protected] wrote:

@catsgotmytongue https://github.com/catsgotmytongue - can you please help me and give some more details. I downloaded your changes as a zip but I'm not sure what to place into the tinymce plugins folder. If I try to place the ice and icesearchreplace from what you have within tinymce/plugins I get uncaught reference errors. Can you please explain what we need to do to get this working. PS: THANK SO MUCH!

— Reply to this email directly or view it on GitHub https://github.com/NYTimes/ice/pull/76#issuecomment-60963208.

— Reply to this email directly or view it on GitHub https://github.com/NYTimes/ice/pull/76#issuecomment-61038888 . https://github.com/notifications/beacon/ACxzrGEiKNhn12Kr9EDJUydM0A3rSyGVks5nIZ8PgaJpZM4AxpqX.gif

[catsgotmytongue]

@jhermiz Can you send me ([email protected]) a zip of the files you're having trouble with ? You may have to rename the extension from zip in order for you to send it to me on gmail.

I'm having trouble pinning down what the issue is, maybe I can figure it out and then send them back to you and maybe update my github branch once I figure out what the issue is.

[tbclarkson3]

Curt, I also tried to make this work so, it would be very helpful if you could pass along anything that you find.

Thank you for doing this.

Tom

On Nov 3, 2014, at 9:57 PM, Curt Mullin [email protected] wrote:

@jhermiz Can you send me ([email protected]) a zip of the files you're having trouble with ? You may have to rename the extension from zip in order for you to send it to me on gmail.

I'm having trouble pinning down what the issue is, maybe I can figure it out and then send them back to you and maybe update my github branch once I figure out what the issue is.

— Reply to this email directly or view it on GitHub.

[asleg]

Hi! I too would very much like to get thos workkng with TinyMCe4. I'm running tinyMce with a knockout-binding, thus I need to initiate ice from within the bindingshandler.

I'm having some challenges with the downloaded version og Tinymce thus am using the CDN. Would be nice if ice was configurable as a local plugin, but that is maybe outside ice's control?

[asleg]

Sorry about the spellings. Big thumbs, small phone. ;)

[reedlaw]

Is anyone having trouble using the backspace to delete text while track changes is on?

[dnaber-de]

Yes I discovered such a behaviour in Firefox. But it was a few month ago and the project paused since then. Didn't had the time for further investigations.

[reedlaw]

I've tried two forks, both @catsgotmytongue's and @TinderBox's, but neither allow backspace. I'm thinking of switching to CKEditor which has a working ice plugin.

[BharatDPatel]

Hi,

First of all thanks a lot and appreciate the work of ICE plugin. We are using TinyMce 4.1.7 version in our project. We are having requirement of integrating Track changes capabilities in tinymce editor for review purpose.

We check the demo and sample provided on GitHub. We are able to integrate it and it works fine. However the tinymce.js in that sample is of version 4.0b1. We need to integrate ICE with tinymce 4.1.7. After implementing the changes and registering the ICE plugins it shows error “Could not load plugins/ice/plugin.min.js”.

I have attached the error screen. I will be grateful if you can Please help us out in resolving this issue. Also Please suggest if we are missing anything. Or steps.

[MillenniumV3]

@BharatDPatel simple copy plugin.js (in the plugins/ice directory) and rename it to plugin.min.js.