ice icon indicating copy to clipboard operation
ice copied to clipboard

Delete event issue

Open coorasse opened this issue 12 years ago • 10 comments

When I delete text inside a TinyMCE text area it gets deleted correctly and the change tracked but if I delete all the text (not just inserted) and hit DEL for the last time it deletes also the del ice span removing the info about the deletion. It happens in Firefox and Chrome too with TinyMCE 3.5.8 and ice last version.

coorasse avatar Mar 16 '13 17:03 coorasse

I think this may have been fixed in recent commits on master. Can you test out the latest from master in your project - replace [tinymce_plugins]/ice/js/ice.min.js with this.

delambo avatar Mar 18 '13 02:03 delambo

I will try it thing evening. Actually that is the version I'm using in my project: https://github.com/coorasse/Airesis/tree/master/app/assets/javascripts/ice

You eventually can see the bug in my test app located at http://airesistest.alwaysdata.net/proposals/260-testa/edit You can login as: username: [email protected] password: testtest

If you delete the whole content in any of the TinyMCE text areas you can reproduce the bug.

coorasse avatar Mar 18 '13 10:03 coorasse

Those are inserts from the same user. Users can delete their own inserts, so it is not strange that it is being deleted.

johanneswilm avatar Mar 18 '13 10:03 johanneswilm

I tried removing the ice javascript files and using the ice-master.min.js file you provided to me but the problem persists. I confirm you I am using the latest version of ice libray

coorasse avatar Mar 18 '13 22:03 coorasse

There was a problem when I tried to open your test app. Did Johannes explain the problem accurately? If you are deleting a same-user insert, then that does not get tracked.

delambo avatar Mar 18 '13 23:03 delambo

Sorry now the app is working right. I was updating it right now..:) Yeah I understood Johannes explanation but that's not my case. The text is already inside the textarea. Please try it now.

coorasse avatar Mar 19 '13 00:03 coorasse

The changes aren't showing up because the "Show/Hide changes" button is unselected. If you select that button then they will show up.

delambo avatar Mar 19 '13 00:03 delambo

Yes and everything works (almost) right if I enable it. I made a short video to show you the bug cause my english is not so good so probably I'm not so clear: http://youtu.be/W-GP0v_X5w8 you can set maximum quality to see the text inside firebug ;)

coorasse avatar Mar 19 '13 08:03 coorasse

I just noticed it happens also in the demo page: http://nytimes.github.com/ice/demo/ if you delete the whole content of the TinyMCE text area disabling the track changes view

coorasse avatar Mar 20 '13 21:03 coorasse

Unfortunately, your wonderful video demonstration expired. We just released 0.5.0 and updated the demo. Can you test out your scenario again and let us know if things aren't working as expected?

delambo avatar Dec 09 '13 15:12 delambo