ice icon indicating copy to clipboard operation
ice copied to clipboard

Refactor core functions for better api

Open delambo opened this issue 12 years ago • 2 comments

Some of the core objects in ice use the old JavaScript convention of marking non-api/private functions with an "_". We should refactor these functions out of the core prototype and into the outer closure so that they can only be referenced internally.

I'm not concerned with privacy - "we're all adults around here" - I just want to clean the api/proto of these functions.

delambo avatar Feb 19 '13 19:02 delambo

I have been accessing tracker._addNodeTracking from outside to either wrap entire nodes with all their subelements into a delete tag or deleting them altogether. When inserting them I used tracker.insert . Could we keeo addNodetracking accessible from the outside somehow? And why does it have this odd name, when really what is does is delete nodes?

johanneswilm avatar Feb 22 '13 23:02 johanneswilm

Yeah, that's fine. I've been trying to clean up some of the naming as functions have taken on new or different roles.

delambo avatar Feb 23 '13 14:02 delambo