retour
retour copied to clipboard
nystudio107
Add locale check logic for the redirect
Since Retour has already got locale fields in the database. It makes sense to check for locale when check for redirect.
The locale fields is displayed on the list of redirects and can be edited as well.
I didn't see this until now; it looks good! Can you do the PR against the develop branch though please?
@khalwat Sorry it took a bit long. I didn't check my email until yesterday. All good now
@bighoho123 No worries at all, I very much appreciate the PR. I may have to merge it in the next release, just because it looks like there may be some minor cleanup needed in the case of a site not being localized, and the test matrix I need to set up to ensure it does the right thing.
@khalwat It's an awesome project so the pleasure is mine.
FYI, I did put some logic to check if craft is being localized or not by using shouldMatchLocale() in RetourService.
@bighoho123 yeah I just need to do a bunch of sanity checking on it is all; there are many sites that use Retour, often with hundreds of redirects set up already.
I just want to do some testing to make sure it isn't going to change the behavior they are experiencing on their site currently.
You must be crazy busy since the release of Craft 3, any idea when you will get a change to merge this one in?
