craft-seomatic icon indicating copy to clipboard operation
craft-seomatic copied to clipboard

[FR] Support Vizy fields as meta source fields

Open yoannisj opened this issue 2 years ago • 10 comments

Describe the bug

Vizy fields don't appear in source field dropdowns in the Content SEO settings for entry sections.

To reproduce

  1. Add a Vizy field to a given Entry Type
  2. Go to SEOMatic > Content SEO > Entry Section from Step 1
  3. Select the Entry Type from Step 1 in the dropdown on the top left
  4. Select "SEO Description Source > From Field"
  5. Open the "Source Field" dropdown
  6. The Vizy field from Step 1 is not listed in the dropdown options

Expected behaviour

Vizy fields can contain text which may be useful for SEO descriptions. It would be great if we could select Vizy fields as SEO field sources, for both the "From Field" and "Summary from Field" options.

Versions

  • SEOMatic version: 3.4.24
  • Vizy version: 1.0.12
  • Craft version: 3.7.32

yoannisj avatar Apr 16 '22 16:04 yoannisj

Changing this to a feature request

khalwat avatar Apr 17 '22 04:04 khalwat

@khalwat Is there a mechanism for me to add support for Vizy fields, or is that all more or less hardcoded on your end?

engram-design avatar Aug 15 '22 06:08 engram-design

Hard-coded-ish on my end, but shouldn't be too hard for me to add here: https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Field.php & https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Text.php

khalwat avatar Aug 15 '22 15:08 khalwat

Just realised that it would make sense to support Vizy field as source for Asset fields in sitemaps:

We often use Vizy fields as rich text fields (i.e. without adding any block type) because of how it stores the formatted the text as JSON (which gives us more control on how to render the field in the frontend).

For example: in the screenshot below Assets in the "Images" volume have a block-less Vizy field named "Description" where editors can add a caption to the images. The text stored in that field would be the best match for the Asset's "Caption" field in sitemaps, but it is currently not selectable:

ScreenShot 2022-10-17 at 11 21 30

yoannisj avatar Oct 17 '22 10:10 yoannisj

Would also love to be able to add a Vizy field as the source for SEO description. Specifically "Summary from field".

gregorydavidjenkins avatar Nov 08 '22 22:11 gregorydavidjenkins

Very doable

khalwat avatar Nov 09 '22 01:11 khalwat

Any updates on this?

torgeirbeyer avatar Feb 28 '23 10:02 torgeirbeyer

I'm planning to slate this for the next release!

khalwat avatar Mar 15 '23 21:03 khalwat

Has this been released @khalwat ?

torgeirbeyer avatar Nov 28 '23 09:11 torgeirbeyer

Not yet; sorry for promising it in the next release, and not delivering.

khalwat avatar Nov 28 '23 14:11 khalwat