react-native-raw-bottom-sheet icon indicating copy to clipboard operation
react-native-raw-bottom-sheet copied to clipboard
verified publisher icon nysamnang

Please type props with 'PropsWithChildren'

Open fkranenburg opened this issue 3 years ago • 2 comments

Our typescript compiler is complaining about Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<RBSheet> & Readonly<RBSheetProps>'. and it looks like this is because of RBSheetProps is missing PropsWithChildren

fkranenburg avatar Sep 07 '22 10:09 fkranenburg

This PR fixes the issue https://github.com/nysamnang/react-native-raw-bottom-sheet/pull/146

I've used patch-package for now

guy-shahine avatar Oct 02 '22 22:10 guy-shahine

well, it did not yet, @guy-shahine you guys have to merge it

gabk17 avatar Oct 12 '22 09:10 gabk17

Am still having the same issue on my RN typescript project.

rick427 avatar Oct 30 '22 19:10 rick427

@gabk17 I don't have proper permissions to merge, I approved the PR and waiting for the repo maintainers to merge and release a patch

guy-shahine avatar Nov 02 '22 19:11 guy-shahine

Need this fixed. Hope patch will be released soon.

alalfakawma avatar Jan 20 '23 11:01 alalfakawma

Not fixed yet.

Arvo-palma avatar Mar 29 '23 19:03 Arvo-palma

@nysamnang please consider merging this PR. It would solve a simple type definition issue for many people without altering any functionality. Thanks!

rowbot-weisguy avatar Jul 05 '23 20:07 rowbot-weisguy

Merged #146

nysamnang avatar Mar 07 '24 04:03 nysamnang