nym icon indicating copy to clipboard operation
nym copied to clipboard

Re-enable vested delegation migration + contract migration for fixing existing mistakes

Open jstuczyn opened this issue 1 year ago • 1 comments

This PR does introduces two things to the mixnet contract:

  • it fixes and re-enables code for migrating vested delegation into the liquid one and correctly handles case when somebody already has a liquid delegation towards the same mixnode
  • it introduces migration to recompute amount of tokens missing towards each specified node and using ratios provided in MigrateMsg (which got very painstakingly determined by scraping our chain) it either adds additional tokens to existing delegations or, if somebody decided to undelegate everything, creates brand new delegation in that place.

oh and there's plenty of unit tests for the both additions... not going to make the same mistake twice lol


This change is Reviewable

jstuczyn avatar Oct 09 '24 13:10 jstuczyn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 2:09pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 2:09pm

vercel[bot] avatar Oct 09 '24 14:10 vercel[bot]

superseded by https://github.com/nymtech/nym/pull/4977 which removes the contract migration code as it's already been run

jstuczyn avatar Oct 16 '24 15:10 jstuczyn