"pending_messages" and "recently_closed" should be periodically cleared.

Open jstuczyn opened this issue 5 years ago • 2 comments

This issue is very similar to https://github.com/nymtech/nym/issues/424 as it also refers to cleaning up stale data. However, this can apply to both socks5 client and network requester.

Both socks5 client and network requester keep track of ids of all 'recently' closed connections and messages received out of order (not to be confused with OrderedMessage. this ONLY refers to receiving 'Send' before a 'Connect'). However, that data is NEVER cleared meaning that at some point we can simply run out of memory. Also it can be relatively easily abused...

Nov 10 '20 10:11 jstuczyn

@jstuczyn - do you still see this being problematic now?

Nov 21 '22 12:11 tommyv1987

@jstuczyn - do you still see this being problematic now?

yup, it's still very much a thing

Nov 21 '22 12:11 jstuczyn