nymea-plugins icon indicating copy to clipboard operation
nymea-plugins copied to clipboard

Published 20 hours ago • verified publisher icon nymea

WIP: New plugin - smartcar

Open gpaulbot opened this issue 3 years ago • 3 comments

nymea-plugins pull request checklist:

  • [x] Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"

  • [ ] Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.

  • [ ] Did you update the plugin's README.md accordingly?

  • [ ] Did you update translations (cd builddir && make lupdate)?

  • [ ] If you added a new plugin, should it be added to nymea-plugins-all or nymea-plugins-maker?

gpaulbot avatar Jul 09 '21 08:07 gpaulbot

Can one of the admins verify this patch?

nymea-jenkins avatar Jul 09 '21 08:07 nymea-jenkins

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 09 '21 08:07 CLAassistant

Also, please add the dpkg files so it will be packaged by CI:

  • add package in debian/control
  • add debian/nymea-plugin-smartcar.install.in

Not sure if we need to add it to any meta package (last point from checklist), probably not as the vast majority of users out there won't have a supported car yet.

mzanetti avatar Jul 09 '21 11:07 mzanetti