James Nylen

Results 174 comments of James Nylen

We are out of time for beta1, milestoning this for beta2.

It is, but it's the _ClassicPress_ version that gets appended, which doesn't make sense to me.

This is also the default behavior of WordPress. Look at the source code of https://wptavern.com for example: ``` ```

https://github.com/ClassicPress/ClassicPress/pull/297 adds a `classicpress_asset_version` filter which helps with this.

Checking `filemtime` on every request isn't something we should ship out to everyone because it hurts performance for servers with slow filesystems. I didn't notice that was in the child...

You are understanding the purpose of cache busting correctly, but we can think through the specific implementation more carefully, with the goal of avoiding unnecessary server-side operations on every request....

Yes, it should be fine to use the same function.

I didn't think of pulling this data from the GitHub API. Let's do it, I think that will work really nicely. The release entries for 1.0.0 and 1.0.1 already have...

Requests would not be frequent, we could store the result in a very long transient (1 month for example). 2 reasons for this: - One more place where we need...

Postponing this issue until later, since there is still a lot to do in order to make it work. >Or, we could take the simplest route and just add a...