nylas-php icon indicating copy to clipboard operation
nylas-php copied to clipboard

Published 20 hours ago • verified publisher icon nylas

Added functions for Deltas

Open harrysinghtiwana opened this issue 10 years ago • 2 comments

Added function getDeltas, getDeltaCursor and createAuthHeader

harrysinghtiwana avatar Sep 13 '15 07:09 harrysinghtiwana

Hi @lawcus. Thanks for the pull request!

This pull request looks good to me; I only have three concerns:

  1. It would be nice if getDeltas returned a list of NylasAPIObjects instead of plain JSON arrays.
  2. Could you update README.md too?
  3. Are you using an IDE? I see you have changed indent style for all the braces in the file. Please revert this.

Also, to merge this I'd need you to sign our Contributor License Agreement. It's similar to the one used by meteor and nodejs.

regards,

Karim

khamidou avatar Sep 14 '15 09:09 khamidou

We will update it to NylasObject as well as READMe.md in next update. Yes, we are using PHPStorm, removed the braces. Also, we have signed Agreement. Thanks!

harrysinghtiwana avatar Oct 04 '15 06:10 harrysinghtiwana