nylas-mail icon indicating copy to clipboard operation
nylas-mail copied to clipboard

Published 20 hours ago • verified publisher icon nylas-mail-lives

I can't empty trash

Open ohynek96 opened this issue 7 years ago • 14 comments

It would by nice to have some sort of empty button in trash folder or possibility to manually delete emails from this folder.

ohynek96 avatar Sep 25 '17 08:09 ohynek96

And from the spam folder

Aleixenandros avatar Sep 26 '17 15:09 Aleixenandros

I'd like to tackle this one. :)

LiHRaM avatar Oct 01 '17 19:10 LiHRaM

I'm thinking something like this, where there's a delete button next to the importance marker and an empty all option at the top. Any thoughts?

image

LiHRaM avatar Oct 01 '17 21:10 LiHRaM

I think that this layout would be perfect. Maybe "Empty Trash now" button will be enough. Because if we talk about Trash folder I can think about only two action. First to recover some email and second to empty trash (all emails at once). Also option for automatically empty trash after closing the app can be useful.

ohynek96 avatar Oct 02 '17 08:10 ohynek96

I like it! If there is an option for automatically emptying trash (not necessary), it should be turned off by default

mikeseese avatar Oct 02 '17 13:10 mikeseese

Well, there is already a function for automatically emptying trash every n days. Instead of creating a new option for emptying trash every time you close, how about changing the setting to 1 day? I don't know if this is possible within Nylas, but that would be a more feasible option, I think.

LiHRaM avatar Oct 03 '17 07:10 LiHRaM

https://github.com/nylas-mail-lives/nylas-mail/blob/eb532c574769419be9af7e96a349c67fdc545a5c/packages/client-app/spec/mailbox-perspective-spec.es6#L182

This looks like bad news. Does anyone know why this wasn't possible at the time, and whether or not it is possible now?

LiHRaM avatar Oct 11 '17 20:10 LiHRaM

that was way before our (the open source community) time

mikeseese avatar Oct 11 '17 20:10 mikeseese

https://github.com/nylas/nylas-mail/issues/599

dweremeichik avatar Oct 11 '17 23:10 dweremeichik

If anyone is interested, I've been working on porting it from Mailspring here: https://github.com/LiHRaM/nylas-mail/tree/feature/empty-trash-bengotow

LiHRaM avatar Oct 27 '17 15:10 LiHRaM

Hi @LiHRaM , i am first time contributor, do you need help with that. If yes could you please guide me to start out the work

M-ZubairAhmed avatar Nov 01 '17 08:11 M-ZubairAhmed

@M-ZubairAhmed If you join the slack channel, we can try pairing and finishing this finally. :)

LiHRaM avatar Nov 02 '17 11:11 LiHRaM

@LiHRaM Do you need any help with this? I can pitch in :)

nirmit avatar Nov 22 '17 04:11 nirmit

@nirmit That would be appreciated. I have a university project I'm turning in, in a couple of weeks, so I'm pretty busy.

LiHRaM avatar Nov 22 '17 11:11 LiHRaM