makepackage icon indicating copy to clipboard operation
makepackage copied to clipboard

Published 20 hours ago • verified publisher icon nyggus

Change setup to pyproject

Open nyggus opened this issue 1 year ago • 8 comments

Pyuthon is moving from setup.py files to pyproject.toml files. makepackage should too.

nyggus avatar Feb 16 '23 07:02 nyggus

I think this is a good direction for makepackage, will try and work on that.

patrickboateng avatar Feb 19 '23 23:02 patrickboateng

I' am happy to see that. I lack time to contribute to the package the way it deserves.

nyggus avatar Feb 20 '23 03:02 nyggus

I have created a pull request which includes a pyproject.toml file for packaging makepackage.

patrickboateng avatar Feb 25 '23 14:02 patrickboateng

Thanks. Please gimme some time to review this - and I will try to make this time reasonable. Please let me know in what environments (OSs) you checked this.

nyggus avatar Feb 27 '23 12:02 nyggus

On windows

patrickboateng avatar Feb 28 '23 09:02 patrickboateng

And which Python version? We need to check it in all main Python 3.6 and higher versions. I will check also on Linux.

I added a comment to the merge request. We need a pyproject.toml file not only in the package itself, but also in the packages it creates.

nyggus avatar Feb 28 '23 10:02 nyggus

yeah yeah, I will add that, but I want to know if nothing is breaking as of now?

patrickboateng avatar Feb 28 '23 11:02 patrickboateng

I have added the pyproject.toml file when makepackage is invoked. Let me know of any feedback. I am using Python 3.9

patrickboateng avatar Feb 28 '23 16:02 patrickboateng