react-share icon indicating copy to clipboard operation
react-share copied to clipboard

Published 20 hours ago • verified publisher icon nygardk

Update react peerDependencies to support React 18

Open alexdrimbe opened this issue 3 years ago • 6 comments

alexdrimbe avatar Apr 12 '22 09:04 alexdrimbe

@nygardk Could you take a look for this PR?

kpman avatar Jun 15 '22 09:06 kpman

It would be great to have support for react 18

sukantamaikap avatar Jun 27 '22 10:06 sukantamaikap

@nygardk, the changes have been approved, can you merge it?

alexdrimbe avatar Jul 21 '22 08:07 alexdrimbe

@nygardk, can you please merge and release these changes?

skb1129 avatar Aug 16 '22 04:08 skb1129

This patch has a lot in it, besides just updating the peer deps. Would a simpler/cleaner PR have a greater chance of getting merged?

CaptainN avatar Aug 17 '22 21:08 CaptainN

I made a super simple, one line PR #464

CaptainN avatar Aug 18 '22 17:08 CaptainN

Thanks. React 18 has been supported in peerDeps since version 4.4.1.

nygardk avatar Nov 18 '23 12:11 nygardk