obsidian-pocket icon indicating copy to clipboard operation
obsidian-pocket copied to clipboard

Fix if empty getSetting of item-notes-folder

Open erdivartanovich opened this issue 1 year ago • 1 comments

Today I start using this plugin to sync obsidian with my pocket account. As I am not use any special folder for Pocket note, I leave the correspondent setting as default (blank). But I found that the initial configuration will get error every time this plugin try to create a new note from a pocket link.

Reproduce step:

  • Fresh install this plugin
  • Connect your account to pocket
  • Open pocket list
  • Click any pocket title will throw this error: image

So I start digging locally, and create this fix. It is working well now using my fork.

Additional Notes Along the way of fixing I found wrong reference import to "utils" module, which apparently in the code base the module name is actually "Utils". I don't know if this is a typo or something else but I fix it nonetheless.

Do you think this fix is relevant or not? probably you could merge it to the upstream.

PS: Nice works from you, I will probably use this plugin in daily basis and maybe will help along the way.

erdivartanovich avatar Mar 23 '23 13:03 erdivartanovich

Can we get this merged? I'm having the same problem

rgomezp avatar Feb 27 '24 08:02 rgomezp