Brendan Shaklovitz

Results 16 comments of Brendan Shaklovitz

The link wasn't a permalink and doesn't seem to show the bug. In `enumerateWithToken` function ([permalink](https://github.com/trufflesecurity/trufflehog/blob/21258f416008f1e389a1e38b1af08ec5651b9d54/pkg/sources/github/github.go#L301-L309)) - an enterprise client is created if the endpoint doesn't match `https://api.github.com`. `enumerateUnauthenticated` doesn't...

Following up on this, it would be awesome to build more frequent releases. I'd definitely like to use a more recent version of the code. I'd suggest adding this PR...

I was going to have a go at fixing this, but I wasn't able to reproduce this with `trufflesecurity/trufflehog:latest` (currently version 3.33.0 - docker digest `sha256:cbd819592ecd569a495884a024d1d425cb0acc4d5a515375a22115b362c21cc1`).

I think you could go a few ways on it, but it's essential that the errors get returned in `FromData` calls so that callers know to retry (e.g., that they...

I think overall this is okay with me, but this might be good to get feedback from other consumers of the tool. One change I might make is to optionally...

:eyes: I like the approach of using `req.URL.Host` here so that you keep at least some minimum info in the error. Not having any indication that the URL was redacted...