actions-netlify icon indicating copy to clipboard operation
actions-netlify copied to clipboard

Use with page speed insights

Open kaihendry opened this issue 5 years ago • 8 comments

Could you please illustrate how you would use https://github.com/nwtgck/actions-netlify#outputs with https://github.com/marketplace/actions/page-speed-insights ?

Thank you!

kaihendry avatar Apr 06 '20 08:04 kaihendry

@kaihendry Hi,

Here is the yaml.

...
      - name: Running Page Speed Insights
        uses: jakepartusch/psi-action@v1
        with:
          url: ${{ steps.deploy-to-netlify.outputs.deploy-url }}
          threshold: 70
          strategy: mobile

full: https://github.com/nwtgck/actions-netlify/blob/85450f952f626b64861a3facdb5d19519fea07f8/.github/workflows/test.yml

Here is the actual changes: https://github.com/nwtgck/actions-netlify/pull/85/commits/85450f952f626b64861a3facdb5d19519fea07f8 #85

Result

image

Actions: https://github.com/nwtgck/actions-netlify/pull/85/checks?check_run_id=564141914

nwtgck avatar Apr 06 '20 11:04 nwtgck

Didn't work on https://github.com/kaihendry/dabase.com/pull/10 ... any ideas why?

Something obviously with the URL https://github.com/kaihendry/dabase.com/pull/10/checks?check_run_id=566227674

Maybe the name is wrong? https://github.com/kaihendry/dabase.com/blob/master/.github/workflows/netlify.yml

kaihendry avatar Apr 07 '20 02:04 kaihendry

Would prefer to see Pagespeed output on the PR itself...

image

kaihendry avatar Apr 07 '20 02:04 kaihendry

I'm not sure why the error caused. But it says " ##[error]Url is required to run Page Speed Insights."

image

nwtgck avatar Apr 07 '20 04:04 nwtgck

Have you tried the following setting? Because the error might not cause by actions-netlify.

...
        with:
          url: "https://dabase.com/"
          threshold: 70
          strategy: mobile

nwtgck avatar Apr 07 '20 04:04 nwtgck

@kaihendry Have you tried this?

nwtgck avatar Apr 14 '20 09:04 nwtgck

I think it had an error because it was a draft. To run it you would need the draft to be published.

AllanOricil avatar Apr 24 '20 13:04 AllanOricil

@kaihendry ping?? I'd like to close the issue when you solved this.

nwtgck avatar May 29 '20 12:05 nwtgck