add: auto_inactive:false to createDeploymentStatus

[nojvek]

Github automatically makes any previous environments stale, if there is a new deployment status. With Netlify, the urls still remain valid even if there is a new status.

In our case, we use netlify for PR builds i.e every commit gets a unique netlify link. The issue is Github UI loses that link when anyone else adds a new commit.

By making auto_inactive: false, the links would preserve and Github's UI would be useful.

[nojvek]

fyi @nwtgck ^

[nwtgck]

@nojvek Thanks. I have not tried auto_inactive: false yet.

What about clicking the following ✅ and go Netlify? Each commit has ✅.

[nojvek]

That works. Although the deployment that shows at the bottom near the review section goes stale when any new deployment with same environment is made.

This would save 2 clicks, and be less confusing as the deploy link would always be there.

[nojvek]

@nwtgck - any blockers on merging this?

[nwtgck]

No blocking. I've not tryied auto_inactive:false yet.

[nojvek]

Kind ping on this @nwtgck ^

I know can clone this repo to unblock myself, but would be nice to land this one line change and keep it in orig repo.

[nojvek]

Another kind ping on this @nwtgck plz.

[nojvek]

Just following up. Anything blocking?

[nwtgck]

I apologize for the very long wait. I finally tried this feature on https://github.com/nwtgck/use-actions-netlify/pull/25. But unfortunately, I'm not sure the difference between auto_inactive: false and without it.

[andersonba]

ping