actions-comment-run icon indicating copy to clipboard operation
actions-comment-run copied to clipboard

PR merge preview and then also create Pull request

Open kaihendry opened this issue 4 years ago • 3 comments

AFAICT after testing https://github.com/nwtgck/actions-comment-run#pr-merge-preview it creates a local branch actions-merge-preview/... with the proposed third party change.

But I was expecting it go one step further, create the pull request and run the CI / Github action, like I manually did here: https://github.com/kaihendry/dabase.com/pull/9

The goal here is to streamline the review of the change. I'm a little worried if the third party (original) PR is updated, https://github.com/kaihendry/dabase.com/pull/8 then would the PR 9 get subsequently updated too? I think it will, though it would require another PR merge preview action wouldn't it?

kaihendry avatar Apr 02 '20 02:04 kaihendry

@kaihendry

But I was expecting it go one step further, create the pull request and run the CI / Github action, like I manually did here: kaihendry/dabase.com#9

You said " create the pull request". Does "The pull request" mean "another pull request"?

nwtgck avatar Apr 03 '20 12:04 nwtgck

@kaihendry The purpose of "pr-merge-preview" is to get merged result of a PR from forked repo. After checking a preview branch of the PR, I expect that you merge the PR and remove the preview branch.

nwtgck avatar Apr 03 '20 12:04 nwtgck

AFAICT https://github.com/nwtgck/actions-comment-run#pr-merge-preview creates a new branch under your "OWNER" user.

Btw is allowed-associations: '["OWNER", "COLLABORATOR"]' a construct of yours? I am surprised Github workflows doesn't appear to support this construct of setting what privileged user can run the workflow! https://github.com/search?q=%22allowed-associations%22&type=Code

Ok, once the new branch exists, to get CI and a Preview running, I find that I need to create another pull request unless I am mistaken?

kaihendry avatar Apr 06 '20 08:04 kaihendry