purescript-language-server icon indicating copy to clipboard operation
purescript-language-server copied to clipboard

Should optional field return null?

Open klarkc opened this issue 2 years ago • 1 comments

I was attempting to trace the root cause of mattn/vim-lsp-settings#692, and I found that purescript-language-server is returning null values for optional fields (like documentChanges). Is this intended, and should the LSP client handle null as optional fields?

klarkc avatar Nov 21 '23 02:11 klarkc

Yeah I imagine these should be absent rather than null, not sure if this is the lsp server itself or the library used. We should probably be using undefined instead of null in the representation, if that works out the same as absent by the time it gets to the wire

nwolverson avatar Nov 23 '23 14:11 nwolverson