pvoc-rs
pvoc-rs copied to clipboard
Separate analysis and synthesis
This pull request separates the analysis from the synthesis. The purpose is to enable things like time stretching.
Haven't had a chance to look at this in detail yet, but I'm fully supportive of this change! This would greatly expand the use cases. Thanks!
Thank you for your kind words and for reviewing my pull requests!
I would like to try out the proposed API myself in order to test it and this may take some time, but I got distracted by other things, so it may take a while longer. So here are some things we can do:
- Just keep the PR open a little longer. There aren't many people contributing to this crate, so this probably doesn't block anybody.
- Remove the
pub
keyword for the new structs. This would allow us to change the API later and then it wouldn't be a breaking change.
What do you think about it?
My sincere apologies for forgetting about this! I'm thinking what would be best is either to keep the PR open, or to merge it onto a new branch. Then when things are done I can merge with the master branch. Up to you.
@nwoeanhinnogaehr , no worries. The limiting factor is the amount of time I have. I think we'll just leave the PR open. When I have validated that the API is ergonomic, I can let you know that it's ready for review and if I notice some usability problems, I can still push commits.