nw.js icon indicating copy to clipboard operation
nw.js copied to clipboard

nwjs truncating chrome args from package.json on windows

Open zkrige opened this issue 1 year ago • 4 comments

Issue Type

Before opening an issue, please search and see if it has already been raised.

  • [x] Bug Report
  • [x] Successfully reproduced against the latest version of NW.js?

from package.json "chromium-args": "--enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent='' --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags='--no-flush-bytecode' --disable-web-security --allow-file-access --allow-file-access-from-files --enable-experimental-web-platform-features ",

from chrome://flags \nwjs-sdk-v0.91.0-win-x64\nw.exe" --remote-debugging-port=9222 --enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags=--no-flush-bytecode --disable-web-sec�I"

this is what was causing https://github.com/nwjs/nw.js/issues/8218 - I had enable-gcm at the end and it was being truncated and not sent to chrome

so a couple of my chrome flags arent actually being sent to chrome - this appears to happen only on windows

zkrige avatar Sep 20 '24 11:09 zkrige

Most likely related to #7670. Although I noticed that the character count in your repro is 284 - not sure what's going on there 👀

ayushmanchhabra avatar Sep 21 '24 07:09 ayushmanchhabra

Remote debugging port isn't part of the package.json - it's a node command line parameter

The 260 limit seems to be on args set in package.JSON

@rogerwang this is currently affecting over 500 000 devices running our app

We urgently need a fix here

zkrige avatar Sep 21 '24 07:09 zkrige

closing because duplicate of #7670

zkrige avatar Sep 21 '24 10:09 zkrige

Reopening this for visibility

zkrige avatar Oct 08 '24 05:10 zkrige

@rogerwang does this mean #7671 can be closed?

ayushmanchhabra avatar May 05 '25 02:05 ayushmanchhabra