nw.js icon indicating copy to clipboard operation
nw.js copied to clipboard

%webkit_ver in "user-agent" has what looks like null pointer address output

Open bluthen opened this issue 1 year ago • 6 comments

Issue Type

Before opening an issue, please search and see if it has already been raised.

  • [x] Bug Report

  • [ ] Feature Request

  • [x] Successfully reproduced against the latest version of NW.js?

Please use our mailing list or Gitter chatroom to ask questions. The issue tracker is only for bugs and feature requests, in English only. Please note that issues without a repro or code snippet are less likely to be resolved.

Current/Missing Behavior

Having a package.json of:

{
  "name": "nwjstest",
  "main": "index.html",
  "user-agent": "%webkit_ver"
}

Gives the following in navigator.userAgent:

537.36 (@0000000000000000000000000000000000000000)

Expected/Proposed Behavior

I expect it to show instead:

537.36 (KHTML, like Gecko)

Additional Info

  • Operating System: Linux/MacOS, probably windows but had not tested it.
  • NW.js Version: 0.87
  • Repro Link:
  • Code snippet:
{
  "name": "nwjstest",
  "main": "index.html",
  "user-agent": "%webkit_ver"
}
  • Crash report:

bluthen avatar Apr 24 '24 20:04 bluthen

https://github.com/chromium/chromium/blob/4ad3f3d83c07658158584d9df33c2deb71ac11a3/content/common/user_agent.cc#L93 Looks like the zeroes are supposed to be the chromium git version.

ayushmanchhabra avatar Jul 21 '24 11:07 ayushmanchhabra

Is the expected output exactly 537.36 (KHTML, like Gecko)?

ayushmanchhabra avatar Jul 21 '24 11:07 ayushmanchhabra

Yes, I hard coded it for me instead of using %webkit_ver

bluthen avatar Jul 21 '24 19:07 bluthen

What is the last version that you know this was working? I feel like this could be an easy fix.

ayushmanchhabra avatar Aug 29 '24 03:08 ayushmanchhabra

We noticed it going from v0.78.1 -> 0.87.0

However trying v0.30.0, still shows the issue to me now. So maybe it has something to do with running on newer systems?

bluthen avatar Sep 03 '24 20:09 bluthen

Shouldn't be the case since the characters after the @ should be the Chromium git commit. Maybe something in the build config changed?

ayushmanchhabra avatar Sep 04 '24 07:09 ayushmanchhabra