Visual push Notification showing chrome icon

[meraj321]

NWJS Version : 0.45.0 Operating System : Win10

Expected behavior

Visual notification icon should be configurable, that is, it should be possible to enable or disable chrome logo on visual notification through package.json

Actual behavior

Visual notification is displaying chrome logo at left-top corner and custom (application's) logo on bottom-right corner.

How to reproduce

It can be easily reproduce by using build in notification APIs. I used sample code from https://github.com/nwjs/nw.js/wiki/Notification, and it is reproducible with that.

[meraj321]

Hi,

This issue is still reproducible with nw.js version 49. It's displaying a built- in chrome logo along with an app icon in push notification.

Thanks, Meraj

[TheJaredWilcurt]

After opening all files that ship with NW.js (SDK and Normal) in Resource Hacker, none of them contained a Chromium logo as a replaceable icon.

Reproduction:

• package.nw.zip

Can reproduce in:

Version	Flavor	OS	Arch
0.42.5	SDK	Windows 7	x64
0.49.2	Normal	Windows 7	x64
0.49.2	SDK	Windows 7	x64
0.49.2	SDK	Ubuntu 17	x64

Cannot reproduce in:

Version	Flavor	OS	Arch
0.14.7	SDK	Windows 7	x64
0.33.4	SDK	Windows 7	x64
0.49.2	SDK	OSX 10.11	x64

[meraj321]

I think nw.dll is linked with binary format of chromium logo.

Thanks, Meraj

On Wed 11 Nov, 2020, 8:00 PM The Jared Wilcurt, [email protected] wrote:

Can reproduce in 0.49.2 (normal and SDK) (on Windows 7 x64).

[image: notify] https://user-images.githubusercontent.com/4629794/98823495-28521500-2400-11eb-80ae-1353bc214dd8.png

After opening all files that ship with NW.js (SDK and Normal) in Resource Hacker, none of them contained a Chromium logo as a replaceable icon.

Reproduction:

• package.nw.zip https://github.com/nwjs/nw.js/files/5524516/7435-package.nw.zip

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nwjs/nw.js/issues/7435#issuecomment-725455053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKVAJGRE4VXM265WAAQGS2LSPKNZTANCNFSM4MFIFP6A .

[gouxiwen]

How to solve this problem?I'm using version 0.50.2

[jonlepage]

https://developer.mozilla.org/en-US/docs/Web/API/Notification

just replace img by a blank image

const notification = new Notification('To do list', {
  body: text,
  icon: img
});

[gouxiwen]

just replace img by a blank image

That doesn't solve my problem

[jonlepage]

i dont know , is work on my side !

[gouxiwen]

i dont know , is work on my side !

I see. Using badge, you can change the default chrome icon，thanks！

[jonlepage]

i dont know , is work on my side ! I see. Using badge, you can change the default chrome icon，thanks！

ya and the official documentation have weird description ! They maybe need change this , because it mean nothing !

[panther7]

Still doesn't fixed, example for reproduce it:

chrome.notifications.create("xxx", { "title": "Bacon Ipsum", "type": "basic", "priority": 2, "contextMessage": "Bacon Ipsum", "requireInteraction": true, "iconUrl": "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7", "message": "Bacon ipsum dolor amet short ribs cupim jerky, ribeye boudin shoulder salami fatback beef ribs turducken strip steak. Swine cow turkey picanha shankle spare ribs." }, () => { const err = chrome.runtime.lastError; console.log(err || true); })