nw.js icon indicating copy to clipboard operation
nw.js copied to clipboard

Native find support

Open lengstrom opened this issue 11 years ago • 22 comments

Does NW support any sort of find system?

Example: In Google Chrome, when you press control - f, you get a find window that shows a series of highlighted words on the site that match your pattern. Does node-webkit have anything like this?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

lengstrom avatar Jul 10 '14 03:07 lengstrom

something like this could be integrated in node-webkit or built into the client app.

https://github.com/padolsey/findAndReplaceDOMText

skhavari avatar Oct 29 '14 23:10 skhavari

This should be working with latest version now.

In 0.13 we changed to an optimized architecture so more features can be supported, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

The new version would fixed many issues reported here and we're scrubbing them. This issue is closed as we believe it should be fixed. Please leave a message if it isn't and we'll reopen it.

nwjs-bot avatar Sep 18 '16 04:09 nwjs-bot

There's nothing in the above release 0.13 documentation that says anything about native find support being added. Was this feature actually added? If so, in which release? Where's the documentation?

eriegz avatar Sep 21 '16 18:09 eriegz

Can someone confirm if this works? I tried but didn't work for me. I don't see any UI options on clicking Ctrl+F.

PriteshGajjar008 avatar Mar 20 '17 06:03 PriteshGajjar008

Its not working with latest version 0.21.3. Please advice.

PriteshGajjar008 avatar Mar 20 '17 07:03 PriteshGajjar008

Any updates on this?

PriteshGajjar008 avatar Mar 23 '17 05:03 PriteshGajjar008

I see this is reopened. @Christywl Can you provide your view on this issue please?

PriteshGajjar008 avatar Mar 24 '17 04:03 PriteshGajjar008

Yes, I tried on nwjs-sdk-v0.21.3, it doesn't work. Users can't use CTRL-F to search for a word.

Christywl avatar Mar 24 '17 05:03 Christywl

Okay. Let us know when you guys are planning to work on this.

PriteshGajjar008 avatar Mar 24 '17 06:03 PriteshGajjar008

Thanks for your patience. We plan to fix it soon by providing an API and you can bind it to the hotkey. It shouldn't be a default behavior.

rogerwang avatar Mar 24 '17 06:03 rogerwang

@rogerwang So, any news on this? Couldn't find on documentation/google

peq42 avatar Dec 10 '18 22:12 peq42

+1

franck34 avatar Dec 12 '18 18:12 franck34

This is depending on #5875 , which has some progress recently. This feature should be easy to implement after that one is done.

rogerwang avatar Dec 17 '18 12:12 rogerwang

+1

colorao avatar May 18 '19 09:05 colorao

+1

truesolarflame avatar Oct 22 '19 22:10 truesolarflame

I created an easy to use tool as a temporary stand in.


find-in-nw


Usage

  1. npm install --save findinnw
  2. In your HTML file add:
    <script src="node_modules/findinnw/dist/find-in-nw.js"></script>
    <script>
      findInNw.initialize();
    </script>
    
  3. Use CTRL+F and ESC to show/hide the search box

API

  • https://github.com/nwutils/find-in-nw

TheJaredWilcurt avatar Oct 28 '19 02:10 TheJaredWilcurt

any update on this?

prominentdetail avatar May 13 '20 03:05 prominentdetail

I'll start adding browser features (including this) after #7230 is resolved.

rogerwang avatar May 13 '20 04:05 rogerwang

Is there an opportunity to fund this work?

calumsult avatar Feb 24 '21 22:02 calumsult

@calumsult you could put a bounty on this feature via BountySource or IssueHunt.

rogerwang avatar Feb 25 '21 01:02 rogerwang

So... nothing yet? (sad face)

gusazevedo avatar Oct 19 '21 16:10 gusazevedo

any updates on this?

yushghimire avatar Apr 01 '22 15:04 yushghimire

Checking in on this...

DavidAccola avatar Feb 23 '23 20:02 DavidAccola